Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Status of Knowhere #482

Open
liliu-z opened this issue Mar 26, 2024 · 4 comments
Open

Refactor the Status of Knowhere #482

liliu-z opened this issue Mar 26, 2024 · 4 comments
Labels

Comments

@liliu-z
Copy link
Collaborator

liliu-z commented Mar 26, 2024

Instead of throwing exception, Knowhere report error code out. But these error codes are not will designed:

  1. Too many type and no clear instruction how to use them.
  2. User doesn't know whether this error is retryable.
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@github-actions github-actions bot added the stale label Apr 26, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
@liliu-z
Copy link
Collaborator Author

liliu-z commented May 20, 2024

/reopen

@sre-ci-robot
Copy link
Collaborator

@liliu-z: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot sre-ci-robot reopened this May 20, 2024
@github-actions github-actions bot removed the stale label May 21, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@github-actions github-actions bot added the stale label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants