Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: default session hit function logic is counter productive #592

Open
deven298 opened this issue Dec 30, 2023 · 0 comments
Open

[Bug]: default session hit function logic is counter productive #592

deven298 opened this issue Dec 30, 2023 · 0 comments

Comments

@deven298
Copy link

Current Behavior

When the same session is passed in the adapt function. The default session function check_hit_session will return False if the session_id already exists cache_session_ids. Later, the get_scalar_data function will return None if check_hit_session return False for the existing session_id and skip checking the cache data.

Expected Behavior

Ideally, if session_id exists in the cache_session_ids then check_hit_session function should return True so the cached data is further evaluated based on similarity evaluation function and so on.

Steps To Reproduce

No response

Environment

No response

Anything else?

I am building native support using GPTCache package so it is hard to provide reproducing steps. Feel free to comment on the issue and we can connect externally to discuss reproducing steps if the above description is not clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant