The expediency of using the MvcEvent

[popovserhii]

I've wanted to adapt your module to ZF Expressive but see that code is using MvcEvent.
Expressive application doesn't have any registered "application" class and that to cause the problem.
I've gone through the code and see that there isn't real usage of MvcEvent. This only need to getting Request object.
Can we reduce using of MvcEvent and simply inject Request object?

[kokspflanze]

hi @popovserhii

from my site, i never used the zf-expressive way, so i know just some basics about it.
all in all, we have to refactore many parts in the module, and think about the handling.

But we have to start to think about the dependencies, at the begin, what we can remove and optimize.

if you want you can join https://gitter.im/zfc-datagrid/Lobby maybe we can think together about it.

[imonteiro]

Hi @kokspflanze @popovserhii
Any news on this?

[popovserhii]

Hi @imonteiro
I've implemented support of ZF Expressive in my fork (branch expressive) and this works very well but it has BC with previous versions and cannot be simply merged in a current master. You can try to use it, simply change composer requirement to my fork

  "require": {
	"zfc-datagrid/zfc-datagrid": "dev-expressive"
  },
  "repositories": [
	{
	  "type": "vcs",
	  "url": "https://github.com/popovserhii/zfc-datagrid"
	}
  ]

add ZfcDatagrid\ConfigProvider::class, to config/config.php and run composer update.

We can cooperate and implement support of ZF Expressive, but @kokspflanze should tell how to organize the process.

[kokspflanze]

hi @popovserhii atm i work on next version, i dont have a problem if the module can support both, expressive and mvc, is that possible, or to much differences?
I hope it is possible and we can start with it into the develop, that will be version 2.0.

[popovserhii]

@kokspflanze, there is only one thing, we should discard from MvcEvent and use Request object instead. I can do PR in develop branch since the code is written and ready to use.

[kokspflanze]

@popovserhii okay, sure you can open a PR with that =), so big goal for 2.0 will be the Expressive support.
in develop i already changed typehints and add the fluent interface.