Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just help and questions #18

Open
romanoh opened this issue Nov 28, 2018 · 4 comments
Open

Just help and questions #18

romanoh opened this issue Nov 28, 2018 · 4 comments

Comments

@romanoh
Copy link

romanoh commented Nov 28, 2018

sorry to post here, but i dont now how to get it to work, should i put all the files in my movies folder?

edit:
i now it now but it gives some error:
Excepção não processada: System.ArgumentException: O nome de directório D:\Torrents" é inválido.
em System.IO.FileSystemWatcher..ctor(String path, String filter)
em SubSync.SubtitleSynchronizer.Start() em E:\git\SubSync\src\SubSync\Logic\SubtitleSynchronizer.cs:line 50
em SubSync.Program.Main(String[] args) em E:\git\SubSync\src\SubSync\Program.cs:line 60

i put it:
SubSync.exe "D:\Torrents"

does it go for subfolders also?

@zerratar
Copy link
Owner

zerratar commented Nov 28, 2018

Hey there @romanoh this is perfectly fine to post it here. It seems like there is a double quoutes on the end of the directory path:
nome de directório D:\Torrents" é inválido.

I've seen this issue before and seem to be a bug with dotnet core. So try running subsync like following:

SubSync.exe D:\Torrents

Instead.

does it go for subfolders also?

Yes, it does! 😄

Edit: I can't remember if the issue happened if you run SubSync.exe from a .bat file or from a shortcut with the argument having a double quoute. But you could try either. Otherwise just go without the quoutes as you don't have any space in the folder name anyway.

@romanoh
Copy link
Author

romanoh commented Nov 28, 2018

It seems it is working now removing the quotes.
some questions:
can it download 2 subtitles: exemple: english and Portuguese at the same time (or one or the other if it is the only one)?
where it goes to fech the subtitles?
it needs to be open to auto syncrnonize ?
if the subtitle already exits it wll write above it?

thank you for your great work

@romanoh romanoh changed the title just help Just help and questions Nov 28, 2018
@zerratar
Copy link
Owner

Great that it worked now!

Alright, all of them are great questions.

can it download 2 subtitles: exemple: english and Portuguese at the same time (or one or the other if it is the only one)?

Unfortunately right now it will only download one of the subtitles. So if you start subsync with the parameter -lang portuguese;english it will try and download a portuguese subtitle if one exists, otherwise it will try and get the english one.

Future update will include a postfix on the subtitle filenames with the language code, that will allow multiple languages to be downloaded.

where it goes to fech the subtitles?

Latest commit changed so that SubSync will only download subtitles from OpenSubtitles.com
But earlier versions also included a subtitle fallback search on subscene in case the subtitle couldnt be found on OpenSubtitles. However the fallback logic was faulty and would sometimes put the download in a bad loop. And was therefor removed until it has been remade.

if the subtitle already exits it wll write above it?

No, not at all. If a subtitle already exists it will just skip that video. It will never overwrite an existing subtitle file. However! There are cases when a subtitle file will still be downloaded even though one exists. And that is when the existing subtitle filename is not the same as the video filename.

@romanoh
Copy link
Author

romanoh commented Nov 28, 2018

I think i have a problem:
this

SubSync.exe D:\Torrents -lang portuguese;english
https://i.imgur.com/H4hlXJi.png

dont work , it just freeze only q button work
if i do this

SubSync.exe D:\Torrents
https://i.imgur.com/KndBcK8.png

, it starts syncronyzing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants