Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support west manifest --resolve and --freeze with manifest.project-filter #667

Open
mbolivar-nordic opened this issue Jun 1, 2023 · 1 comment

Comments

@mbolivar-nordic
Copy link
Contributor

#664 disabled west manifest --resolve and west manifest --freeze whenever manifest.project-filter is set. This is intended as a temporary limitation. This issue tracks an enhancement to west where the two are made compatible again.

The proposed semantics are:

  • inactive-by-default: true (if implemented, see [RFC] New inactive-by-default: project key #666 ) and manifest.project-filter will NOT affect the output of west manifest --resolve
  • corollary: if bsim includes inactive-by-default: true in the upstream zephyr manifest, users will need to activate bsim manually in order to be able to use west resolve, because e.g. west manifest --resolve will need to resolve the import in the bsim project definition. If the project is missing, the command should produce an error saying that west update is needed (to get bsim itself and all of the projects it imports).
@mbolivar-nordic
Copy link
Contributor Author

Expected behavior in an example:

manifest.project-filter == `-bsim` # forbidden to combine with west manifest --resolve today
west update bsim                   # updates bsim, but does not do its import; bsim remains inactive
west manifest --resolve            # works, since bsim is present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant