Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Better pnpm workspace support #182

Open
1 task done
yjl9903 opened this issue Dec 24, 2023 · 1 comment
Open
1 task done

[feature] Better pnpm workspace support #182

yjl9903 opened this issue Dec 24, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@yjl9903
Copy link

yjl9903 commented Dec 24, 2023

Is your feature request related to a problem? Please describe.

In my full-stack pnpm monorepo project, I use the following structure to manage my project.

root
├── packages/
│  ├─ shared1/
│  ├─ shared2/
│  └─ ... # packages shared in this repo
└── apps/
   ├─ frontend/ # A frontend project, may use the shared lib
   └─ backend/  # A backend project, may use the shared lib

Now, zeabur can not properly handle the pnpm monorepo correctly.

For installation, the generated dockerfile only copy and install the deps in the root package.json.

For building, I use some monorepo manager to build all the shared library and frontend app (or backend app).

Describe the solution you'd like

Detect the pnpm workspaces, see details in the pnpm docs.

And then generate dockerfile like:

# ...
Copy package.json pnpm-lock.yaml .
Copy packages/shared1/packages.json ./packages/shared1/
Copy packages/shared2/packages.json ./packages/shared2/
RUN pnpm install
# ...

In my previous experience, docker does not support something like glob pattern?

Describe alternatives you've considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@yjl9903 yjl9903 added the enhancement New feature or request label Dec 24, 2023
@MichaelYuhe
Copy link
Member

Thank you for your suggestion! We highly value your feedback and think this is a great idea. In fact, this proposal is already on our roadmap. We are working to implement it and hope to make it available to all users in the near future. cc @pan93412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants