Reserve bottom space in validation elements for error messages #2492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2484 we noticed that input elements don't reserve bottom space for error messages, which should be the default. This PR makes sure this space is added. There's a "hide-bottom-space" prop if this is undesired. Because this might break existing layouts, this PR targets the v2.0 branch.
I just wonder if we should always reserve the space, or only if the
validation
is notNone
, i.e. a validation dictionary is given. 馃Update: There's another related discussion #2738.