Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lab mr merge does not work #818

Open
BradyHu opened this issue Mar 25, 2022 · 4 comments
Open

lab mr merge does not work #818

BradyHu opened this issue Mar 25, 2022 · 4 comments
Assignees

Comments

@BradyHu
Copy link

BradyHu commented Mar 25, 2022

the lab version is 0.24.0
the gitlab version is GitLab Community Edition 13.12.15

(ez-sdk-IyrY50Hh-py3.9) (base) ➜ ez-sdk git:(CI) ✗ lab mr create origin master -m "docker file"
https://gitlab.citydnatech.com/ez.cloud/ez-sdk/-/merge_requests/5/diffs
(ez-sdk-IyrY50Hh-py3.9) (base) ➜ ez-sdk git:(CI) ✗
(ez-sdk-IyrY50Hh-py3.9) (base) ➜ ez-sdk git:(CI) ✗ lab mr merge
2022/03/25 09:01:18 ERROR: mr_merge.go:40: PUT https://gitlab.citydnatech.com/api/v4/projects/ez.cloud/ez-sdk/merge_requests/5/merge: 405 {message: 405 Method Not Allowed}
(ez-sdk-IyrY50Hh-py3.9) (base) ➜ ez-sdk git:(CI) ✗

it seems that api has been changed, how can i fix it?

@BradyHu
Copy link
Author

BradyHu commented Mar 25, 2022

it seems that /api/v4/projects/<project_path>/merge_requests/<mr_id>/merge has been changed to <project_path>/merge_requests/<mr_id>/merge

@bmeneg
Copy link
Collaborator

bmeneg commented Mar 30, 2022

Oh! Ok, that's interesting, I didn't notice nor saw any changelog on gitlab side about this change.
I'll check it.

Thanls for te report!

@bmeneg bmeneg self-assigned this Mar 30, 2022
@zampierilucas
Copy link
Collaborator

zampierilucas commented May 3, 2022

I don't think this is a lab issue as 405 means:

The merge request cannot be accepted because it is Draft, Closed, Pipeline Pending Completion, or Failed. Success is required.

[1] https://docs.gitlab.com/ee/api/merge_requests.html#:~:text=accept%20this%20merge%20request.-,405,-Method%20Not%20Allowed

@zampierilucas
Copy link
Collaborator

Alternatively, you can force lab to merge a mr with -i, --immediate merge immediately, regardless pipeline results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants