-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude_glob doesn't respect ** operator #1269
Labels
needs-review
Needs attention from a maintainer
Comments
Hi there! Unfortunately, this Issue has not seen any activity for at least 90 days. If the Issue is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed. |
This is still relevant, I am trying to find time to update the PR |
github-actions
bot
added
needs-review
Needs attention from a maintainer
and removed
no-activity
[Bot] Closing soon if no new activity
labels
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
One of the more useful tools in
glob
is being able to use the**
operator to match patterns at any point in the tree; however, that requires therecursive
flag to be turned on in theglob.glob
function: https://docs.python.org/3.9/library/glob.html#glob.globIt appears that that has not been used:
Zappa/zappa/core.py
Line 638 in f2f03ba
and
Zappa/zappa/core.py
Line 770 in f2f03ba
However, the
**
operator is used in the example in the docs:https://github.com/zappa/Zappa/blame/f2f03ba8b58c9e2bdbbff7b5e8c905e3a8c08021/README.md#L951
Expected Behavior
An
exclude_glob
entry with a**
, e.g."**/__pycache__"
should recurse through the directory tree to identify and eliminate matching pathsActual Behavior
**
operators are ignored byglob
Possible Fix
Add the
recursive=True
argument to each of the places whereexclude_glob
paths are usedSteps to Reproduce
exclude_glob
zappa package
The text was updated successfully, but these errors were encountered: