-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FunctionalNamingForHostnames only works with zalando domains #1474
Comments
Sorry for missing to answer timely. Yes, this is a mistake. We should have implemented the rule more general to allow customizing the domain used for the functional host name. You are welcome to make the rule configurable and contribute this back to Zally. Until we have done this, you can disable the rule by either using:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As far as i can tell, it seems like the FunctionalNamingForHostnamesRule only work on zalando domains, i guess this must be a mistake?
https://github.com/zalando/zally/blob/main/server/zally-ruleset-zalando/src/test/kotlin/org/zalando/zally/ruleset/zalando/FunctionalNamingForHostnamesRuleTest.kt
The text was updated successfully, but these errors were encountered: