-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Get, Set and Delete have unexpected and limiting behaviours #102
Comments
FLuzzi-csw
changed the title
[Windows] keyring.Get has unexpected and limiting behaviour
[Windows] Get, Set and Delte have unexpected and limiting behaviours
Jan 24, 2024
FLuzzi-csw
changed the title
[Windows] Get, Set and Delte have unexpected and limiting behaviours
[Windows] Get, Set and Delete have unexpected and limiting behaviours
Jan 25, 2024
Just do understand your use case from a high level, do you want to be able to set a credential with another app and read it with an app using go-keyring? Can you elaborate on the use case you have in mind? |
Yes, you got it right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I've found an issue while retrieving credentials set in the Windows Credential Manager by another application (not using
go-keyring
).Let's take this scenario, the main application sets a new credential to a specific service and username:
serviceName = service:name
username = $YOUR_USERNAME
When trying to call
keyring.Get("service:name","$YOUR_USERNAME")
, the searched service name is created mergingserviceName
andusername
(searchedServiceName = service:name:$YOUR_USERNAME
), this behaviour is implemented in the functioncredName
.This problem is the same also with
keyring.Delete
andkeyring.Set
.Since changing this behavior would break every windows application using this library, I'd propose:
RawGet
,RawSet
andRawDelete
) that skips this behaviour on Windows (on other systems this would be a proxy to the original calls)NOOP
)I'm open to work on this as soon as a decision is taken.
Thanks 😄
The text was updated successfully, but these errors were encountered: