Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XDG home and add colour #69

Closed
wants to merge 5 commits into from
Closed

Use XDG home and add colour #69

wants to merge 5 commits into from

Conversation

tecosaur
Copy link
Contributor

@tecosaur tecosaur commented Sep 9, 2020

This closes #38, and makes the script nicer to look at.

image

@zachcurry
Copy link
Owner

Thanks for this, @tecosaur! I will look this over as soon as I get a chance.

@tecosaur
Copy link
Contributor Author

tecosaur commented Oct 2, 2020

@zachcurry I hope you get a chance soon :)

@tecosaur
Copy link
Contributor Author

@zachcurry maybe around the Christmas holidays, you might have a little spare time? 👀

@tecosaur
Copy link
Contributor Author

Hi @zachcurry 🙂 I tried sending you an email (using your git commit address) two weeks ago.

It would be great to hear if you've recieved it.

@tecosaur
Copy link
Contributor Author

tecosaur commented Feb 7, 2021

I've done a little re-implementation of the ideas here, tecosaur/emacs-everywhere.

As such, I now consider this PR redundant.

@tecosaur tecosaur closed this Feb 7, 2021
@psibi
Copy link

psibi commented Feb 7, 2021

@tecosaur Note that I have another fork which uses a different clipboard mechanism that the one used here: https://github.com/psibi/emacs-everywhere

@tecosaur
Copy link
Contributor Author

tecosaur commented Feb 7, 2021

I see, you just type the contents. I'm not sure how well it would work for large buffers, but seems reasonable. With a bit of extra work, the clipboard approach is working consistently for me though.

@tecosaur tecosaur deleted the qol-changes branch February 7, 2021 14:43
@psibi
Copy link

psibi commented Feb 7, 2021

So far I haven't had any issues. :-) But the problem I had with the old approach was:

  • It interfered with my other clipboard
  • It wasn't reliable at all. It never worked consistently for me.

Eitherwise, let me know if you do change the clipboard approach or make it configurable to add additional approaches. I would like to avoid relying on my fork if possible. :-)

@tecosaur
Copy link
Contributor Author

tecosaur commented Feb 7, 2021

In my rewrite, most of emacs-everywhere-finish is clipboard-related, but you could just add advice to replace that function.
Another thought, I could check the clipboard contents immediately before overwriting, and then restore the clipboard content to that original state.
Assuming you're on Linux, I'd be curious to know if you still have the reliability issues with my package, if you'd be willing to test it out and let me know that would be great :)

@psibi
Copy link

psibi commented Feb 7, 2021

@tecosaur Sure, I will give it a try in a couple of days. I will open an issue in your issue tracker in case if something doesn't work. Thanks you!

@tecosaur
Copy link
Contributor Author

let me know if you do change the clipboard approach or make it configurable to add additional approaches

I've recently pushed tecosaur/emacs-everywhere@d20adad which introduces some new defcustoms:

  • emacs-everywhere-paste-command
  • emacs-everywhere-copy-command
  • emacs-everywhere-window-focus-command

This may be enough, and if not I'm open to a PR adding support for further customisation.

@psibi
Copy link

psibi commented Feb 12, 2022

@tecosaur I gave this a try today and it doesn't seem be working in my setup. This was my session:

❯ emacsclient --eval "(emacs-everywhere)"
nil

~/Downloads via 🦀 v1.57.0
❯

As you can see that it didn't put anything in my terminal after pressing C-x 5 0. Probably I should open an github issue instead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support XDG Base Directory Specification
3 participants