Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the difference between kaldifeat-kaldi and kaldifeat-python? #3

Open
mezhou opened this issue Dec 22, 2020 · 4 comments
Open

the difference between kaldifeat-kaldi and kaldifeat-python? #3

mezhou opened this issue Dec 22, 2020 · 4 comments

Comments

@mezhou
Copy link

mezhou commented Dec 22, 2020

May I ask you the numerical difference between kaldifeat by kaldi implementation and kaldifeat by your python implementation?
I have compared the two computed features, and I find it has some difference.
I wonder that the experiment results showed in D-TDNN master and D-TDNN-kaldifeat branch is absolutely the same.

Thanks~

@yuyq96
Copy link
Owner

yuyq96 commented Dec 22, 2020

Yes, the generated features can be different, but it merely affects the results. There are two reasons for the difference:

  • Floating point precision, which can be ignored.
  • Dither: when you turn it on, we add some randomness to the features, which changes the results. Fortunately, the differences are limited.

However, if you did find some implementation errors in kaldifeat-python, please let me know.

@mezhou
Copy link
Author

mezhou commented Dec 22, 2020

I have turn off the dither and unified the configuration, maybe it because the floating point precision you mentioned.

BTW, is the performance results in your paper/github based on the feature used kaldi official implementation or your python implemention on the fly?

Anyhow, your kaldifeat-python implementation is really a nice work! And thank for your fast reply.

@yuyq96
Copy link
Owner

yuyq96 commented Dec 22, 2020

The performance in our paper is based on Kaldi official implementation to make sure it is exactly the same with previous papers.

@mezhou
Copy link
Author

mezhou commented Dec 22, 2020

OK, I got it.
Thanks again~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants