Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build in webpack #638

Open
2 tasks done
jamesikanos opened this issue Apr 23, 2024 · 5 comments
Open
2 tasks done

Unable to build in webpack #638

jamesikanos opened this issue Apr 23, 2024 · 5 comments
Labels
type:bug Something isn't working

Comments

@jamesikanos
Copy link

Issue Checklist

  • I'm using the library programmatically
  • For Scrcpy related issues, I have searched in Genymobile/scrcpy repository.

Library version

0.0.23

Environment

Node v12.12.0

Device

Linux

Describe the bug

I'm trying to include the library in my own project, but when I try to build I receive these webpack errors:

./node_modules/@yume-chan/stream-extra/esm/push-readable.js - Error: Module build failed (from ./node_modules/@angular-devkit/build-angular/src/tools/babel/webpack-loader.js):
TypeError: /workspaces/site_survey_results/node_modules/@yume-chan/stream-extra/esm/push-readable.js: Cannot read properties of null (reading 'type')

./node_modules/@yume-chan/stream-extra/esm/wrap-readable.js - Error: Module build failed (from ./node_modules/@angular-devkit/build-angular/src/tools/babel/webpack-loader.js):
TypeError: /workspaces/site_survey_results/node_modules/@yume-chan/stream-extra/esm/wrap-readable.js: Cannot read properties of null (reading 'type')

Do I need to change my TSConfig to support this?

I'm adding this to an Angular 17 app.

Steps to reproduce

  1. Create an Angular App
  2. Yarn add the required dependencies
  3. Try to build
@jamesikanos jamesikanos added the type:bug Something isn't working label Apr 23, 2024
@yume-chan
Copy link
Owner

Node v12.12.0

Too old. We only support LTS and stable versions of Node.js.

./node_modules/@yume-chan/stream-extra/esm/push-readable.js - Error: Module build failed (from ./node_modules/@angular-devkit/build-angular/src/tools/babel/webpack-loader.js):
TypeError: /workspaces/site_survey_results/node_modules/@yume-chan/stream-extra/esm/push-readable.js: Cannot read properties of null (reading 'type')

I also don't understand why it need to evaluate that at build time.

@jamesikanos
Copy link
Author

Sorry, that was a typo:

I'm on v20.12.0

@yume-chan
Copy link
Owner

Can you share a complete repro? I'm not familiar with Angular.

@jamesikanos
Copy link
Author

I'll get something new to you within a few days. It's an internal project so I'll make a separate sample.

@yume-chan
Copy link
Owner

It might not work with Angular anyway: #630 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants