ultraman panics if a process is exiting early while processing the stdio of that process

[tardyp]

Steps to reproduce

Simple reproduce (my env is a bit different, and reproduce the panic 100%)

Profile:

early_out: seq 100
sleep: sleep 20

Expected behavior

full 100 lines are displayed to the terminal

Actual behavior

only few lines are displayed.
sometimes, a panic happens:

thread '' panicked at 'called Result::unwrap() on an Err value: "SendError(..)"', #44 $HOME/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ultraman-0.3.1/src/stream_read.rs:44:38

It looks like there is a race-condition between catch of the SIGCHILD, and completion of the stdout/err processing.

System configuration

ultraman version:
0.3.1
Rust version:

[yukihirop]

@tardyp

thank you ☺️

[yukihirop]

full 100 lines are displayed to the terminal

It wasn't fixed

[yukihirop]

I don't know how to fix it, but there was a problem here.
Observed returning EOF immediately...

ultraman/src/output.rs

Lines 37 to 44 in 3dc86f7

	channels.push(PipeStreamReader::new(Box::new(
	proc.lock()
	.unwrap()
	.child
	.stderr
	.take()
	.expect("failed take stderr"),
	)));