[security vulnerability] Arbitrary Order Free Pay

[GatekeeperBuster]

Recently, our team found a vulnerability causing the Arbitrary Order Free Pay in the latest version of the project.

The vulnerability logic is present in the file: https://github.com/youlaitech/youlai-mall/blob/master/mall-oms/oms-boot/src/main/java/com/youlai/mall/oms/service/app/impl/OrderServiceImpl.java#L202.

The developer failed to check the privilege of the accessor when updating status via com.baomidou.mybatisplus.extension.service.impl.ServiceImpl<OrderMapper,OmsOrder>.getById(), while the request of path /payment is also unauthorized (i.e., https://github.com/youlaitech/youlai-mall/blob/master/mall-oms/oms-boot/src/main/java/com/youlai/mall/oms/controller/app/OrderController.java#L59), which means an attacker can achieve Arbitrary Order Free Pay.

To address this vulnerability, we strongly advise that developers implement access control policies that limit API access to admin users or the owner.