Remove Client.subscribe #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chacha912
force-pushed
the
remove-client-subscribe
branch
from
33d5fb7
to
e146411
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
- Coverage 80.46% 80.28% -0.18%
==========================================
Files 59 59
Lines 4432 4439 +7
Branches 890 898 +8
==========================================
- Hits 3566 3564 -2
- Misses 604 612 +8
- Partials 262 263 +1 ☔ View full report in Codecov by Sentry. |
hackerwins
approved these changes
Apr 26, 2024
2 tasks
|
@chacha912 It would be good to update the documentation for the next release. 🙏 |
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
In this PR,
Client.subscribe()was removed, and topicsconnectionandsyncwere added todocument.subscribe().Any background context you want to provide?
What are the relevant tickets?
Fixes #788, #771
Checklist