-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OneOf fields aren't linted #268
Comments
@alexhayes Thank you for reaching out.
Oneof fields are Style Guide mentions Regardless of that, your suggestion might be appropriate as Language Guide uses underscore_separated_names for oneof name. And it makes sense that protolint needs to provide a way to complain about the
|
While writing a custom rule
FIELD_NAMES_CAMEL_CASE
I discovered thatoneof
fields are not linted by the ruleFIELD_NAMES_LOWER_SNAKE_CASE
orFIELDS_HAVE_COMMENT
.For example, if you have;
This will pass linting even with the
FIELD_NAMES_LOWER_SNAKE_CASE
and/orFIELDS_HAVE_COMMENT
enabled - when I'd expect it to complain about theMyField
not being lower snake case and/or containing a comment.Am I correct in thinking this is how it should behave or is that not the intended behaviour? It looks as if that's how it should behave.
The text was updated successfully, but these errors were encountered: