Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup do not hide when disabled is set #293

Open
artemkasan opened this issue Jan 14, 2022 · 1 comment
Open

Popup do not hide when disabled is set #293

artemkasan opened this issue Jan 14, 2022 · 1 comment

Comments

@artemkasan
Copy link

Version

2.0.5

Test Case

https://codesandbox.io/s/reactjs-popup-wrong-disabled-vup57

Hover over "Disable" button. Popup appear. Click "Disable" button.

Expected Behavior

https://react-popup.elazizi.com/component-api#disabled
According to documentation popup must be automatically close after disabled is set.

Actual Behavior

Pop keep open and do not hide when hover out of popup area.

@mriiad
Copy link

mriiad commented Jan 26, 2022

Hello @artemkasan,

I agree with you, I think it's a bug.

@yjose can you confirm this please ?

I corrected it locally ✅ but I still have some failed tests ❌, maybe I will need your help @yjose 🙌🏼

I will create a PR today to keep you updated.

mriiad added a commit to mriiad/reactjs-popup that referenced this issue Jan 28, 2022
Kinjeiro added a commit to Kinjeiro/reactjs-popup that referenced this issue Oct 11, 2023
Popup do not hide when disabled is set yjose#293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants