Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confetti Not Shown in Fullscreen #94

Open
ankpham opened this issue Aug 20, 2022 · 6 comments
Open

Confetti Not Shown in Fullscreen #94

ankpham opened this issue Aug 20, 2022 · 6 comments
Assignees
Labels
bug Something isn't working.

Comments

@ankpham
Copy link

ankpham commented Aug 20, 2022

I am making an app that uses a full screen. However, when the confetti is executed, since the party-js element is outside of my fullscreen div element, it won't show when in full screen. Is there anyway to move the element and nest it inside my own element or manually render it?

@ankpham ankpham changed the title Confetti not shown in fullscreen Confetti Not Shown in Fullscreen Aug 20, 2022
@yiliansource
Copy link
Owner

Hi, the container element should automatically fit to screen size. Could you maybe provide a minimal, reproducable example?

@ankpham
Copy link
Author

ankpham commented Aug 24, 2022

My app allows the div to be viewed in full screen, however, the party js container is outside of that full screen. Therefore, it is not shown in the full screen container as it is not nested within it even if it is scaled to full screen size, it is not included in the full screen.

What I need is the ability to move the partyjs container within my full screen div so that it appears in full screen mode.
I'm using this for full screen: https://www.w3schools.com/howto/howto_js_fullscreen.asp Scroll down to "Fullscreen Document".

  <div className="fullscreen-container">
        Full Screen Content here
  </div>
  <div className="party-js-container"/>

@ankpham
Copy link
Author

ankpham commented Sep 26, 2022

Hey, do you have any updates on this?

@yiliansource
Copy link
Owner

Hi sorry, uni is keeping me busy.

I'm currently not sure on how to approach this, since I'm unsure how the fullscreen API operates. I'll definitely look into this, and I will let you know what I can do!

@yiliansource yiliansource added the bug Something isn't working. label Oct 8, 2022
@yiliansource yiliansource self-assigned this Oct 8, 2022
@ankpham
Copy link
Author

ankpham commented Oct 13, 2022

No worries, take your time!

@ankpham
Copy link
Author

ankpham commented Dec 28, 2022

Hello, the project I'm working on that uses requires the confetti effect to work soon and I believe I've found a solution. Since the fullscreen api selects an element and all its child nodes in it to be viewed in full screen, all that's needed is to have the option to move the confetti container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants