Skip to content
This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

Do not initiallize ACRA with the media code list support #89

Open
JeanPaulLucien opened this issue Dec 21, 2022 · 2 comments
Open

Do not initiallize ACRA with the media code list support #89

JeanPaulLucien opened this issue Dec 21, 2022 · 2 comments

Comments

@JeanPaulLucien
Copy link
Contributor

JeanPaulLucien commented Dec 21, 2022

I did not understand infromation from Acra's developers. Just I investigate Warning about MediaCodecList and Acra's code. I recommend to drop (not initiallize ACRA with the media code list support) these Acra's feature . Reasons:
ACRA/acra#1143
ACRA/acra#1144

I don't know any reason to use the Acra's code to get an information about codecs, because information about codecs are published in the web and placed on device in xml.

@JeanPaulLucien
Copy link
Contributor Author

@vikulin
Looks like Acra's developers say that other app can use only needed modules. You can exclude Acra Media module and the app will be compiled without it. That way decreases quantity of methods and we will not see the string in logs.

Class MediaCodecList has only 2 methods for API 16-21. Yggdrasil is not multimedia app. Seems there is no reason to compile the app with Acra's Media module.

@JeanPaulLucien JeanPaulLucien mentioned this issue Dec 23, 2022
@vikulin
Copy link
Member

vikulin commented Dec 24, 2022

@JeanPaulLucien please prepare ready PR with Multidex fix and ACRA optimization. Separated commits broken the build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants