New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification is only displayed at most once per interval #209
Comments
This behavior is intentional. When we made this package, we wanted it to be as unobtrusive as possible. That being said, I'm open to having an option added that changes the behavior, but I still believe the current behavior is the best default. |
What if the user cannot upgrade for some reason? Then they will be bothered by an update notification they every time they run your CLI. |
Considering there's a way to disable the update-notifier already, they can just temporarily disable it. I can also expose my own way to allow disabling this through our own config, so that it's clearly documented for my users. The notification may even link to that config option doc so that user can disable it very easily |
As of 5.1.0, notifications are displayed at most once per interval period, because the fetched update is deleted once "emitted" (ie set to
this.update
)This is a bit weird to me, wouldn't it be better if the update message was displayed consistently as long as there is an update? Some users might miss that there is an available update quite easily.
Some workarounds I'm using to ensure that once an update gets fetched, it remains visible, and trying to fetch it before the first interval:
Having a more convenient way to achieve all this could be useful
The text was updated successfully, but these errors were encountered: