Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude images by tag #73

Open
yellowbluesky opened this issue Feb 19, 2020 · 4 comments
Open

Exclude images by tag #73

yellowbluesky opened this issue Feb 19, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@yellowbluesky
Copy link
Owner

Should be simple

Will just integrate be more lines in filterRanking() and filterAuth(). Break it out into a separate function?

@yellowbluesky yellowbluesky added the enhancement New feature or request label Feb 19, 2020
@yellowbluesky
Copy link
Owner Author

yellowbluesky commented Feb 19, 2020

Will need testing to see if more than one tag search term works, and the syntax (comma or space delimited etc)

Possibly open a new issue to track this

@yellowbluesky
Copy link
Owner Author

yellowbluesky commented Mar 16, 2020

Will need a Preference, allowing the user to pick what language the search terms are going to be in.

Languages to have are English, Japanese, and Chinese for now. I'm not sure what other languages Pixiv supports, and what their code are. Preference can be a simple DropDownPreference.

As to how to organize it, can PreferenceCategory have sub-PreferenceCategory's? Easy to test when I have the time

@yellowbluesky
Copy link
Owner Author

yellowbluesky commented Apr 22, 2020

Language selection added in 8aafa71

Tag input not yet implemented. I'm thinking of having an EditTextPreference, with users entering a comma delimited list of tags to exclude

Also need a way to pass Accept-Language to PixivArtService, perhaps pass them a partially formed Request with only the 'Accept-Langauge' field filled?

@yellowbluesky
Copy link
Owner Author

ArrayAdapter in a ListView would be a much nicer way of managing tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant