-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract vue and react version to seperate packages #1126
Comments
Good suggestion! |
I have to admit that I don't have any experience with this myself. But based on what I've seen, you can start with yarn workspaces and setup publishing etc yourself. Or use build tools such as https://lerna.js.org/ which add additional convenience on top of workspaces. |
Yarn is very old and lerna is also very old, I used to work with them many years ago. Today I work with |
Currently, the vue and react parts are simply exported to
dist
which makes for rather awkward imports such asInstead, I would propose to create new packages that encapsulate these. So for example, one could have
Also has the advantage that one could properly declare dependencies (e.g. currently one has prop-types as peer dependency, but this is react-specific). (You don't have to split the repository, one common mono-repo approach is to have a
packages
folder, with each package being a subfolder there, i.e.packages/vue
,packages/react
andpackages/core
.)This was triggered by DefinitelyTyped/DefinitelyTyped#62368 (comment)
The text was updated successfully, but these errors were encountered: