Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the profiler #82

Open
y-lohse opened this issue Dec 25, 2017 · 3 comments
Open

Port the profiler #82

y-lohse opened this issue Dec 25, 2017 · 3 comments

Comments

@y-lohse
Copy link
Owner

y-lohse commented Dec 25, 2017

There's now a Profiler in ink, which still needs to be ported to ink.js. It was part of #80.

I've done a bit of work on it on the profiler branch. The tricky parts are the ones relying on C# dictionary functions such as OrderBy, GroupBy, etc.

There are also a number of profiler hooks that need to be added to Story.js.

@NQNStudios
Copy link
Contributor

I might take a crack at this!

@y-lohse
Copy link
Owner Author

y-lohse commented Jul 23, 2018

Cool, let us know how it goes :)

I think the profiler hooks have been added in Story.js now. But the main profiler definitely hasn't!

@ephread
Copy link
Collaborator

ephread commented Jul 23, 2018

I confirm that I've added them in Story.js during the v8 port and since profiler is null for now, they don't do anything. I've also added a TODO comment on top of empty methods dealing with starting / stopping the profiler.

Double checking that haven't missed any hook will be definitely required, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants