-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve encode/decode performence #33
Labels
enhancement
New feature or request
Comments
darkskygit
added a commit
that referenced
this issue
Nov 17, 2023
this PR partially solves #33 and greatly improves the performance of apply update test cases show a performance improvement of about 40-50%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just connected yocto to a community-created benchmark and found that the performance of the codec part was significantly lower than other crdt implementations: https://github.com/darkskygit/crdt-bench-native
![image](https://private-user-images.githubusercontent.com/25152247/281736467-9ed9406d-fd3e-4872-8952-60d09f1d64c5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1MzQ5MTAsIm5iZiI6MTcxOTUzNDYxMCwicGF0aCI6Ii8yNTE1MjI0Ny8yODE3MzY0NjctOWVkOTQwNmQtZmQzZS00ODcyLTg5NTItNjBkMDlmMWQ2NGM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAwMzAxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkyYTRhYmE0MDYyYTQyOGUzY2RlNGYzNWNmNjJkNmVjMTZjZjIyYTQ0ZDBiNzFkZTRjNmQ3NmZiYWI3YTllZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bh2szDLhc_Aj8Vf6hjsCC_b8PleYs96Oh_m73EUW9I8)
![image](https://private-user-images.githubusercontent.com/25152247/281736522-af5dc15d-25df-4724-9c42-af1a264417c3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1MzQ5MTAsIm5iZiI6MTcxOTUzNDYxMCwicGF0aCI6Ii8yNTE1MjI0Ny8yODE3MzY1MjItYWY1ZGMxNWQtMjVkZi00NzI0LTljNDItYWYxYTI2NDQxN2MzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAwMzAxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRhNjA5MDk5NjY1YzA0NWFiNmM3NThhYTg3ODg3YTFlNTU2M2M3MWFiM2E0YTM0ZWZkNjQzMTkwNWZmYjBhNjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cf_FZjldXZvC1LA5rKX_VkNQVhssnFJ1t8Gdq4g8fNQ)
![image](https://private-user-images.githubusercontent.com/25152247/281736551-d3e1201c-4eaf-4c20-a44b-241acb2547e7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1MzQ5MTAsIm5iZiI6MTcxOTUzNDYxMCwicGF0aCI6Ii8yNTE1MjI0Ny8yODE3MzY1NTEtZDNlMTIwMWMtNGVhZi00YzIwLWE0NGItMjQxYWNiMjU0N2U3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDAwMzAxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU0Y2I1ODVlYzllMTc2ZjIxMzZjMDUyM2M0MzhjNTU1MThkNDA4ZjlhN2UwYTRhOGZkM2UxZGM1MDRiYTUxMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.yx0TRYxoHLWm3ndgX3R1a5hpbupyWytHdrTn9PhAT-s)
After a simple inspection, it was found that the current implementation took a lot of time on memory allocation.
The text was updated successfully, but these errors were encountered: