Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collate is not generating a correct query #290

Open
alessandrolulli opened this issue Jan 24, 2024 · 0 comments
Open

Collate is not generating a correct query #290

alessandrolulli opened this issue Jan 24, 2024 · 0 comments

Comments

@alessandrolulli
Copy link

Describe the bug
The collate sqlalchemy function is not correctly handled in the Clickhouse dialect

To Reproduce
from sqlalchemy.sql.operators import collate

query.collate(asc("display_name"), "en"))

it generates the following query:
SELECT ... FROM test WHERE ... ORDER BY display_name ASC COLLATE en LIMIT 0, 300

Expected behavior
The correct query should be:
SELECT ... FROM test WHERE ... ORDER BY display_name ASC COLLATE 'en' LIMIT 0, 300

Also, using query.collate(asc("display_name"), "'en'")) is not fixing

Do you have any suggestions?
Versions
0.3.0

@alessandrolulli alessandrolulli changed the title Collate is not generate a correct query Collate is not generating a correct query Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant