Ask for key password one time

[joyshukla]

Local OS (where xxh is installed): MacOS
Destination host OS: ubuntu/lxc containers
xxh version: xxh/0.8.6
xxh-plugins installed: xxh-plugin-zsh-ohmyzsh

Steps to Reproduce

1. I run xxh ... +v root@myhost and the output log is below

Load xxh config from /Users/****/.config/xxh/config.xxhc
Load xxh config for host myhost
Final arguments list: ['+I', 'xxh-plugin-zsh-ohmyzsh', '+hhh', '~', '+v', 'root@myhost']
ssh arguments: ['-o', 'StrictHostKeyChecking=accept-new', '-o', 'User=root']
**Enter passphrase for key '/Users/****/.ssh/id_rsa':**
Pexpect result:
{'user_host_accept': None, 'user_host_password': None, 'user_key_password': "'", 'output': '\r\nxxh_home_realpath=/root/.xxh\r\nxxh_version=0.8.6\r\nxxh_shell_exists=1\r\nxxh_home_writable=1\r\nxxh_parent_home_writable=1\r\nrsync=/usr/bin/rsync\r\nscp=/usr/bin/scp\r\nshell=\r\nkernel=Linux\r\narch=x86_64\r\n'}
Host info:

xxh_home_realpath=/root/.xxh
xxh_version=0.8.6
xxh_shell_exists=1
xxh_home_writable=1
xxh_parent_home_writable=1
rsync=/usr/bin/rsync
scp=/usr/bin/scp
shell=
kernel=Linux
arch=x86_64

**Enter passphrase for key '/Users/****/.ssh/id_rsa':**
Load plugin /root/.xxh/.xxh/shells/xxh-shell-zsh/build/zsh-bin/bin/../../../../../plugins/xxh-plugin-zsh-ohmyzsh/build/pluginrc.zsh

2. the same issue doesn't occur if using ssh.

For community:
⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

[anki-code]

Hi @joyshukla! Thank you for reporting this! I can reproduce.
PR is very welcome!

[anki-code]

I think the fix should be around this line.

[joyshukla]

I tried this. this alone will not solve the issue. it seems like the passphrase is not passed through correctly. will check more on this soon.

…

On Nov 1, 2020, at 12:34 PM, anki-code ***@***.***> wrote: I think the fix should be around this line <https://github.com/xxh/xxh/blob/master/xxh_xxh/xxh.py#L149>. Something like: if user_key_password: sess.sendline(user_key_password) elif key_password: sess.sendline(key_password) else: user_key_password = getpass.getpass(prompt=(sess.before + sess.after).decode("utf-8")+' ') sess.sendline(user_key_password) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEUA22VQWAVKJHSUF2UHDBDSNXA5HANCNFSM4TGW4P4Q>.

[anki-code]

Hi! I've made some cleaning in the logic.

But the issue couldn't be solved now because when you have a key with password you should enter the password every ssh connection. To solve this for the simple password authentication we use sshpass but we have no solution for the key auth with password.

There are some approaches to solve this:

1. Use pexpect every ssh connection to catch password prompt. This may be slower and with issues but more testing is needed.
2. Or we can pack the ssh commands into one big script and do it once. But we can't achieve just one password typing on this way.
3. Or we can try to find the sshpass for the keys. Short googling says no.
4. Or (user based solution) use the key without password and put it to the key storage behind the password.

[bdoublet91]

Hi,
Do you have a solution for this ?
Thanks for your job !