-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: try to fix AppVeyor failure due to outdated Maven version #1894
base: master
Are you sure you want to change the base?
Conversation
The simplest thing didn't work. Although there is an environment variable
Maven is not mentioned on https://www.appveyor.com/updates/ |
@cmarchand , is this something you're familiar with? |
Do we need to include commands to install Maven when the version we get by default isn't the one we want? Here's an example: https://github.com/Riverside-Software/sonarlint-eclipse/blob/629c37e33e7eed6ac56ddbaa7d569579d9bf1885/appveyor.yml#L5 |
When I tried adding installation commands, they appeared to take effect
but Maven is still running 3.6.0 from a different location that comes first in the path:
|
I'll try to have a look at this tonight. I'm on holidays now, ut I think I'll be able to put 30' on this this evening... |
Thank you!! |
To enable #1833 to avoid the failure we're investigating here, I disabled the Maven operations in AppVeyor (ee4ba74) as part of that PR. I'm mentioning this for 2 reasons:
|
This PR is a "blind" attempt to set a newer Maven version than 3.6.0 in the AppVeyor test run, on top of all the changes for #1833. I don't know how to test this without making a pull request, so it's an experiment.
Removing
test\ci\run-core-tests.cmd
fromappveyor.yml
is just a way to ensure that the build doesn't time out before we find out whether the Maven packaging worked. If all goes well, I'll restore that line.If it works: Fixes #1893