Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop stylistic rules for style lint v15 #20

Closed
wants to merge 3 commits into from
Closed

Drop stylistic rules for style lint v15 #20

wants to merge 3 commits into from

Conversation

fregante
Copy link
Member

@fregante fregante commented Sep 5, 2023 •
edited

Procedure:

  1. I did a search and replace with this regex:
'(at-rule-name-case|at-rule-name-newline-after|at-rule-semicolon-space-before|at-rule-name-space-after|at-rule-semicolon-newline-after|block-closing-brace-empty-line-before|block-closing-brace-newline-after|block-closing-brace-newline-before|block-opening-brace-newline-after|block-opening-brace-space-before|color-hex-case|declaration-bang-space-after|declaration-bang-space-before|declaration-block-semicolon-newline-after|declaration-block-semicolon-newline-before|declaration-block-semicolon-space-after|declaration-block-semicolon-space-before|declaration-block-trailing-semicolon|declaration-colon-newline-after|declaration-colon-space-after|declaration-colon-space-before|function-comma-newline-after|function-comma-newline-before|function-comma-space-after|function-max-empty-lines|function-parentheses-newline-inside|function-parentheses-space-inside|function-whitespace-after|linebreaks|max-empty-lines|media-feature-colon-space-after|media-feature-colon-space-before|media-feature-name-case|media-feature-parentheses-space-inside|media-feature-range-operator-space-after|media-feature-range-operator-space-before|media-query-list-comma-newline-after|media-query-list-comma-newline-before|media-query-list-comma-space-before|no-empty-first-line|no-eol-whitespace|no-extra-semicolons|no-missing-end-of-source-newline|number-leading-zero|number-no-trailing-zeros|property-case|selector-attribute-brackets-space-inside|selector-attribute-operator-space-after|selector-attribute-operator-space-before|selector-combinator-space-after|selector-combinator-space-before|selector-descendant-combinator-no-non-space|selector-list-comma-newline-after|selector-list-comma-newline-before|selector-list-comma-space-after|selector-list-comma-space-before|selector-max-empty-lines|selector-pseudo-class-case|selector-pseudo-class-parentheses-space-inside|selector-pseudo-element-case|string-quotes|unicode-bom|unit-case|value-list-comma-newline-after|value-list-comma-newline-before|value-list-comma-space-after|value-list-comma-space-before|value-list-max-empty-lines|indentation)': [^,]+,
  1. Ran another one without the ' to find non-escaped properties
  2. Fixed the single options object left behind
  3. Ran locally to ensure all deprecated rules were removed

@fregante fregante marked this pull request as ready for review September 5, 2023 03:58
@sindresorhus
Copy link
Member

Why not just switch to https://github.com/elirasza/stylelint-stylistic? There are many useful stylistic rules like color-hex-case.

@fregante
Copy link
Member Author

fregante commented Sep 5, 2023

"Just" implies it was common knowledge that:

  1. That existed
  2. Prettier wasn't equivalent to the missing rules
  3. Is as easy as a search and replace

Closing for now 😅

@fregante fregante closed this Sep 5, 2023
@fregante fregante deleted the stylistic-rules branch September 5, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop deprecated stylistic rules for style lint v15
2 participants
@fregante @sindresorhus