Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest field like STRUCT with COMMENT is not handled #137

Open
kukigai opened this issue Jun 28, 2022 · 4 comments
Open

Nest field like STRUCT with COMMENT is not handled #137

kukigai opened this issue Jun 28, 2022 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@kukigai
Copy link

kukigai commented Jun 28, 2022

I tried latest version simple-ddl-parser==0.26.4 but didn't work.

Sample schema.

CREATE EXTERNAL TABLE aaa.bbb (
test ARRAY<STRUCT<xyz: STRING COMMENT 'xxxxxx',
date: STRING COMMENT 'xxxxxxx'>> COMMENT 'xxxxxx',
)
COMMENT 'xxxxx'
PARTITIONED BY (date STRING)
STORED AS PARQUET LOCATION 's3://xxxxx'

When COMMENT is removed, it worked fine.

@kukigai kukigai changed the title Nest field like STRUCT is not handled Nest field like STRUCT with COMMENT is not handled Jun 28, 2022
@xnuinside
Copy link
Owner

@kukigai thanks for reporting the issue, I will take a look

@kukigai
Copy link
Author

kukigai commented Jul 5, 2022

@xnuinside

Thanks! This is blocking my work so if you are busy, let me know. I could see if I can send PR.

@xnuinside
Copy link
Owner

@kukigai yeah, I don't have a time last days :/ because of work project, and not sure what will have a time till weekends

@kukigai kukigai changed the title Nest field like STRUCT with COMMENT is not handled Nest field like STRUCT is not handled Aug 8, 2022
@kukigai kukigai changed the title Nest field like STRUCT is not handled Nest field like STRUCT with COMMENT is not handled Aug 8, 2022
@xnuinside xnuinside added the help wanted Extra attention is needed label Nov 1, 2022
@soujyosen
Copy link

Is there any update on this? This is an important use case for us with struct columns having comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants