-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make display-buffer-alist configuration customizable #188
Comments
We may have to make the defcustom accept a function, since it'd have to resolve "(regexp-quote (buffer-name buffer))" to the current buffer name. The challenge being that these buffers can change in name, specially if either chatgpt-shell-swap-model-version or chatgpt-shell-swap-system-prompt are invoked on the shell.
What if we uniquely append instead? Would the user customization win? |
Makes sense! For what it's worth, I believe a regexp based matcher for
To be honest, I believe that relying on the list position is a quick fix that works in the user configuration, but should not be the default behavior of a library (if we can help it) because it's so brittle! User customizations can change the list in many ways and then we have the same problem but for different reasons |
Sounds good. Let's go for something more explicit...
Eventually, I'd like to make it much easier to support other llm backends by virtue of moving logic to shell-maker. If at all possible, I'd trying to stay away from adding chatgpt-specific logic if possible. Lemme see if I can add the function-based option to shell-maker. |
This sounds like a sensible decision! Ping me if I can help in any way. |
Sorry for the delay. It'll be quite some time until I rework the compose feature and move it to shell-maker, so better to remove the automatic entry in display-buffer-alist for the time being (e2073d9). I think this should unblock ya? |
Thanks! Don't worry, I'm fine in my own setup |
Currently, the built-in
display-buffer-alist
settings are applied on the fly and thus put in front of the list -- so they always win:chatgpt-shell/chatgpt-shell.el
Lines 1182 to 1188 in 39dd8e7
This makes customization of e.g. the direction in which to display the buffer impossible.
WDYT about making the value a
defcustom
with a default ofso users can use
customize-variable
for tweaks, and alsonil
to disable auto-setting this?The text was updated successfully, but these errors were encountered: