-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing draw_resolution_scale_(x/y)
doesn't seem to resize lines?
#2215
Comments
Custom line widths exist in Vulkan (though not used in Xenia currently), but in Direct3D 12 the configuration for rasterization of lines is pretty limited — overall for now Xenia doesn't even use anything like anti-aliased lines, even though it may be possible that they exist in some form on the Xbox 360, but there's definitely no line width configuration in Direct3D 12 unfortunately. Ideally though for wide lines we should be using a geometry shader, but lines are a pretty rarely used feature overall (though Halo 3 also has them on the loading screen), and they haven't been taken into consideration much so far — especially with regard to resolution scaling, which is overall a low-priority dirty hack. Maybe at some point we'll add such an option though. |
draw_resolution_scale_(x/y)
doesn't seem to resize outlines?draw_resolution_scale_(x/y)
doesn't seem to resize lines?
Apologies for returning to this dead thread; a possible temporary fix could be literally doubling / tripling the lines (or geometry shader) with a bit of position offset depending on the whatever the line scale is? Unsure how that would do performance-wise. |
Validation
Describe what's going wrong
(I'm unsure if "outlines" is the correct wording throughout here, apologizes)
Changing the value on
draw_resolution_scale_(x/y)
doesn't change the size of the outlines in games.For example, I've loaded up two games, Meteos Wars & Ikaruga (great Xbox Arcade titles) to show that this isn't just one game doing this. I've taken screenshots of each game two times, each with and without
draw_resolution_scale_(x/y)
being changed.Meteos Wars:
draw_resolution_scale
set to1
draw_resolution_scale
set to3
Ikaruga:
draw_resolution_scale
set to1
draw_resolution_scale
set to3
The glitched outlines may look different in both games because both menus use outline sizes that ain't the same
This also might be an issue with Direct3D 12, but the other API I've tested, Vulkan, doesn't seem to do anything with
draw_resolution_scale_(x/y)
at all, only rendering at 1x no matter what value.Describe what should happen
Outlines should resize with the current
draw_resolution_scale_(x/y)
set, making games look a little bit better with resolution scaling.If applicable, provide a callstack here, especially for crashes
No response
If applicable, upload a logfile and link it here
I've provided the logs for my tests on Meteos Wars only.
draw_resolution_scale
set to1
logdraw_resolution_scale
set to3
logThe text was updated successfully, but these errors were encountered: