Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git version is missing in rom-o-matic builds #39

Open
NiKiZe opened this issue Sep 6, 2016 · 2 comments
Open

git version is missing in rom-o-matic builds #39

NiKiZe opened this issue Sep 6, 2016 · 2 comments

Comments

@NiKiZe
Copy link

NiKiZe commented Sep 6, 2016

As an example snponly.efi from rom-o-matic shows header:
iPXE 1.0.0+ -- Open Source Network Boot Firmware -- http://ipxe.org
While default build from http://boot.ipxe.org shows
iPXE 1.0.0+ (827dd) -- Open Source Network Boot Firmware -- http://ipxe.org

I think if the git command is missing when building then it becomes 1.0.0+ () -- so not sure if that is the issue or if there is something else going on.

Initially reported by tal____ on IRC

@TalAloni
Copy link

This is important for debugging purposes and should be easy to implement:
Only a single line after the call to "make" in in build.fcgi is needed, something along the lines of:
EXTRAVERSION="+ (".$revision.")"

@shodanx2
Copy link

shodanx2 commented Oct 14, 2022

Hello,
To reiterate, ipxe-buildweb doesn't update the boot banner to include the current version number and github build number

see discussion
ipxe/ipxe#764 (reply in thread)

This causes confusion on an already difficult and confusing topic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants