[Bug]: No a need to stop heartbeat due to one timeout

[Lurker00]

LocalTuya Version

2024.5.0b1

Home Assistant Version

2024.5.3

Environment

• Does the device work using the Home Assistant Tuya Cloud component?
• Is this device connected to another local integration, including Home Assistant and any other tools?
• The devices are within the same HA subnet, and they get discovered automatically when I add them

What happened?

I suggest to replace these lines:

hass-localtuya/custom_components/localtuya/core/pytuya/__init__.py

Lines 920 to 926 in fcc6911

	while self.heartbeater:
	try:
	await self.subdevices_query()
	await asyncio.sleep(HEARTBEAT_SUB_DEVICES_INTERVAL)
	except (Exception, asyncio.CancelledError) as ex:
	self.debug(f"Sub-devices heartbeat stopped due to: {ex}")
	break

with

            wait = 0
            while self.heartbeater:
                try:
                    await asyncio.sleep(HEARTBEAT_SUB_DEVICES_INTERVAL)
                    await self.subdevices_query()
                    wait = 0
                except TimeoutError:
                    wait += 1
                    self.debug(f"Sub-devices heartbeat failed due to timeout {wait} times", force=True)
                    if wait >= 5:
                        break
                except (Exception, asyncio.CancelledError) as ex:
                    self.debug(f"Sub-devices heartbeat stopped due to: {ex}", force=True)
                    break

This is running in my HA server. I didn't see more than 1 time of failures in a row. With the version with the sleep after the query (i.e. no a delay after the timeout), once I saw 3 times, and never more.

I've changed the order of lines 922 and 923 based on your suggestion in #227, and to make a delay after a timeout with minimum changes.

Steps to reproduce.

Don't know.

Relevant log output

2024-05-16 09:55:57.426 WARNING (MainThread) [custom_components.localtuya.core.pytuya] [bf8...m91] Sub-devices heartbeat failed due to timeout 1 times

Diagnostics information.

No response

[xZetsubou]

This has been changed and handled, but I haven't pushed it yet.

[Lurker00]

Just in case, it is worth to make a similar change in start_heartbeat. A gateway may be just busy with other tasks.

[github-actions]

This issue was closed because it was resolved on the release: