-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to merge a set of fix and improvements (done for our application) #24520
Comments
Hello, thanks for the fixes but the usual process would be to open a single PR for each of them, so that they could be tested, discussed and applied independently and I think this would be very much preferable to this "unified" issue. Could you please open separate PRs for your changes? For the bug fixes, it would be great if you could please explain how exactly the problem fixed by your changes can be reproduced (ideal is to add a test failing without the change and fixed by it, but I realize that this is not always easily possible). Thanks in advance! |
Hi, there.
We've developed a commercial cross-platform app using wxWidgets framework for windows/mac/linux, all three mainstream OS are targeted.
And it's a non-trivial app that utilize many features of the framework, we may be one of the most heavy users.
So on the way, we found so many bugs.
We were on rapid development cycles and didn't have the resources to share our fixes to the upstream project on a regular basis, but now we find that we can no longer maintain the fixes, considering the framework is far from mature enough to allow us to stay on one LTS like version, we'd like to request you, the project maintainers to merge in most of our fixes/improvements.
Because there's too many, and in the foreseeable future, more fixes are expected and coming, we'd like to unify the set of works here for the maintainers to review.
Each of the fixes are now in their own branch, created for the sake of the pull request.
Coremail@a28b8db
Coremail@381c608
Coremail@9286889
Coremail@af1f103
Coremail@e998db7
Coremail@8d2ddec
Coremail@f4eb6c3
Coremail@dca4ca3
Coremail@71bf9d8
The 9 fixes/improvements mentioned above are meant to be merged into the master branch.
And the following is one optimization that seems work well in our app,
Coremail@78afe18
The text was updated successfully, but these errors were encountered: