network2 no longer processes successful add/drop responses correctly

[ericpareja]

given a sub_add_resp or sub_drop_resp packet (main type 18 and main type 19) packet, with a zero (success) response, network2 doesn't identify the successful result properly.

here's an older mail with the correct email report.

 Sub: Personal E-Mail                     Msg#: [82 of 177]
From: WWIV AreaFix (WWIVnet) @63          Date: Wed Jan 11 04:29:00 2023      
Subj: WWIV AreaFix (WWIVnet) Response for subtype 'LAMP'
 Sys: aliens' alcove!                      Loc: Taguig City, Philippines        
   

SubType 'LAMP', (add) Response: 'Add or Drop successful'
This is /home/wwiv/data/saLAMP.net

Hello Subscriber! :)


Mail {QSRIDAF?-+GEMZPVUOLCNY@} : 


 Sub: Personal E-Mail                     Msg#: [83 of 177]
From: WWIV AreaFix (WWIVnet) @63          Date: Wed Jan 11 04:44:35 2023      
Subj: WWIV AreaFix (WWIVnet) Response for subtype 'LAMP'
 Sys: aliens' alcove!                      Loc: Taguig City, Philippines        
   

SubType 'LAMP', (drop) Response: 'Add or Drop successful'

here's a recent mail with the Unknown response code 83 report.

 Sub: Personal E-Mail                     Msg#: [146 of 177]
From: WWIV AreaFix (WWIVnet) @63          Date: Wed Feb 15 19:07:22 2023      
Subj: WWIV AreaFix (WWIVnet) Response for subtype 'NEW'
 Sys: Aladdin's Lamp                      
SubType 'NEW', (add) Response: 'Unknown response code 83'

Mail {QSRIDAF?-+GEMZPVUOLCNY@} : 


 Sub: Personal E-Mail                     Msg#: [147 of 177]
From: WWIV AreaFix (WWIVnet) @63          Date: Wed Feb 15 22:55:27 2023      
Subj: WWIV AreaFix (WWIVnet) Response for subtype 'NEW'
 Sys: Aladdin's Lamp                      
SubType 'NEW', (drop) Response: 'Unknown response code 83'

i'll attach test packets and try to identify which commit caused this.

[ericpareja]

@wwiv i've been wracking my brains out on this one, and i know it's hacky to reset the pointer to the start, then increment through the string until the null terminator, but it appears to be the only fix for this.

[wwiv]

Got a test case you can share again with me, I'll take a look

…

On Tue, Feb 28, 2023 at 2:10 PM xenos ***@***.***> wrote: @wwiv <https://github.com/wwiv> i've been wracking my brains out on this one, and i know it's hacky to reset the pointer to the start, then increment through the string until the null terminator, but it appears to be the only fix for this. — Reply to this email directly, view it on GitHub <#1583 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQVX5Q26FNRSML4FXIAOVTWZZZTXANCNFSM6AAAAAAU7DKNXU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ericpareja]

Here's a response packet from node 1 to node 60.
add-success.txt

Email after processing should look like this:

With current code, email after processing looks like this:

[wwiv]

Do I put this in as local.net to process it?

[ericpareja]

Yes.

…

On Thu, Mar 2, 2023 at 4:25 AM Rushfan ***@***.***> wrote: Do I put this in as local.net to process it? — Reply to this email directly, view it on GitHub <#1583 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABN65MONUG5HPXIFH77GM3WZ6WDLANCNFSM6AAAAAAU7DKNXU> . You are receiving this because you were assigned.Message ID: ***@***.***>

-- ___ Eric Manuel Pareja ***@***.***) \e/ PGP/GPG Key 0xB82E42D9 V "Even the smallest person can change the course of the future." -Galadriel