Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Screen Message Reader won't display trailing | pipe chars. #1582

Open
ericpareja opened this issue Feb 16, 2023 · 7 comments
Open

Full Screen Message Reader won't display trailing | pipe chars. #1582

ericpareja opened this issue Feb 16, 2023 · 7 comments

Comments

@ericpareja
Copy link
Contributor

ericpareja commented Feb 16, 2023

Example post:

 _________________________________________
/ Nothing succeeds like the appearance of \
| success.                                |
|                                         |
\ -- Christopher Lascl                    /
 -----------------------------------------
  \
   \   \
        \ /\
        (")
      .(   ).

Example file:
sample.txt

Appears as follows in the BBS in Full Screen Reader mode:
Screenshot from 2023-02-16 18-22-19

Note the pipe character at the end of lines disappears.

@ericpareja ericpareja changed the title bout won't display trailing | chars. bout won't display trailing | pipe chars. Feb 16, 2023
@ericpareja ericpareja changed the title bout won't display trailing | pipe chars. Full Screen Message Reader won't display trailing | pipe chars. Feb 16, 2023
@ericpareja
Copy link
Contributor Author

In Traditional Reader mode, this is how it appears:
Screenshot from 2023-02-22 20-42-35

@wwiv
Copy link
Contributor

wwiv commented Feb 25, 2023

Also wwivutil print does this too.

$ cat x/x.msg
| the world |

$ wwivutil print x/x.msg

|the world

@wwiv
Copy link
Contributor

wwiv commented Feb 25, 2023

This test seems to work, need to dig more:

TEST_F(AnsiTest, HeartAndPipe_TrailingPipe) {
  write_hp("| world |\r\n");
  check({ "| world |" });
}

@wwiv
Copy link
Contributor

wwiv commented Feb 25, 2023

This fails though:

TEST_F(AnsiTest, HeartAndPipe_TrailingPipe) {
  write_hp("| world |");
  check({ "| world |" });
}

@wwiv wwiv closed this as completed in c973b05 Feb 25, 2023
@ericpareja
Copy link
Contributor Author

ericpareja commented Feb 26, 2023

Not fixed. :(

Screenshot from 2023-02-26 15-38-01

Screenshot from 2023-02-26 15-34-15

@ericpareja ericpareja reopened this Feb 26, 2023
@wwiv
Copy link
Contributor

wwiv commented Apr 22, 2023

where's the trailing pipe character there? Sorry, don't understand what was typed vs. expected here.

@ericpareja
Copy link
Contributor Author

Here's the extracted message.
pipe-test.txt

@wwiv wwiv added this to the 5.9: Modern Retro 2023-2024 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants