-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopting astjson package for non-GraphQL use cases? #695
Comments
Hey, astjson doesn't use mergo. It's an indirect dependency, not sure where it's being used. I was already thinking that astjson could be useful for other use cases outside of GraphQL, so making it a standalone go module could be useful. That said, I didn't want to act without a clear need. WDYT? |
I will say it is something I brought up to the other GitHub CLI maintainers as we discuss how to improve our own product experience. Will float this also by @heaths given his time investment on this feature, but I can say it would be valuable in and of itself! 💯 Thank you for taking the time to consider a broader OSS audience, @jensneuse ✨ |
Describe the feature or problem you’d like to solve
Understand how the
astjson
package might be adopted as a module for non-GraphQL router specific use cases such as cli/cli#1268 as an alternative to https://github.com/darccio/mergo.UPDATE: In retrospective, it appears
astjson
usesmergo
under the covers, so understanding whatgraphql-go-tools
adds on top.Additional context
@jensneuse : saw your WunderGraph article on performance improvements with
astjson
at a time where the GitHub CLI team has been trying to figure out how to do something similar with GitHub API requests. In our case, we are making REST and GraphQL API requests on behalf of GitHub users who want / expect a single JSON document when the REST and GraphQL APIs require multiple requests made due to rate limiting.Would appreciate any thoughts and insights you might share!
The text was updated successfully, but these errors were encountered: