Add isFlippedCropRect option
#66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added isFlippedCropRect
sindresorhus
requested changes
May 29, 2019
| @@ -40,7 +40,8 @@ public final class Aperture: NSObject { | |||
| highlightClicks: Bool, | |||
| screenId: CGDirectDisplayID = .main, | |||
| audioDevice: AVCaptureDevice? = .default(for: .audio), | |||
| videoCodec: String? = nil | |||
| videoCodec: String? = nil, | |||
| isFlippedCropRect: Bool? = false | |||
There was a problem hiding this comment.
This parameter needs to be documented in a doc comment. It should say what it does and what it's useful for.
There was a problem hiding this comment.
And it's should not be an optional.
|
The code here is not compiling. Please ensure the code can compile and is working properly (that it actually correctly flips the crop rect). |
|
I think this needs a test. It can just be to run Aperture with certain options and generate a video file with a descriptive name that can be manually verified. |
|
Let us know if you want to continue working on this fix @JakeMakesStuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65