Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink DecodedMessage naming #485

Closed
pklaschka opened this issue Jan 26, 2022 · 0 comments · May be fixed by #645
Closed

Rethink DecodedMessage naming #485

pklaschka opened this issue Jan 26, 2022 · 0 comments · May be fixed by #645
Labels
💣 breaking Issue or PR that includes breaking changes 🍒 on top A feature which doesn't impact the code in a meaningful way but the developer likes it more 🚧 bug Something isn't working 📄 java Pull requests that update Java code 🔧 telestion-api Everything related to the telestion-api module
Projects
Telestion
Milestone
v1.0

Comments

@pklaschka
Copy link
Member

https://github.com/wuespace/telestion-core/blob/35de85b43f58cb223d77f6ac444817b1dbdea49b/modules/telestion-api/src/main/java/de/wuespace/telestion/api/verticle/trait/DecodedMessage.java

Currently, the DecodedMessage serves as a wrapper for both the Vert.x and our own JsonMessage (representing the message's body) types.

However, DecodedMessage could, by itself, also represent a decoded / I..e, typed, message content, meaning these names collide.

We should probably rethink this naming before v1.0.
@pklaschka pklaschka added 🚧 bug Something isn't working 📄 java Pull requests that update Java code 💣 breaking Issue or PR that includes breaking changes 🔧 telestion-api Everything related to the telestion-api module labels Jan 26, 2022
@pklaschka pklaschka added this to Backlog - New Unranked in Telestion via automation Jan 26, 2022
@fussel178 fussel178 added this to the Pre-Release 1.0 milestone Jan 26, 2022
@cb0s cb0s added the 🍒 on top A feature which doesn't impact the code in a meaningful way but the developer likes it more label Jan 28, 2022
Telestion automation moved this from Backlog - New Unranked to Sprint Done Dec 23, 2022
@wuespace-admin wuespace-admin mentioned this issue Dec 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💣 breaking Issue or PR that includes breaking changes 🍒 on top A feature which doesn't impact the code in a meaningful way but the developer likes it more 🚧 bug Something isn't working 📄 java Pull requests that update Java code 🔧 telestion-api Everything related to the telestion-api module
Projects
Telestion
Sprint Done
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

chore(main): release 1.0.0 wuespace/telestion-core
3 participants
@cb0s @pklaschka @fussel178