Prep Mac app for release, fix bugs in iOS app #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For launch, I propose we support the current version of macOS (14.x) and one version earlier (13.x).
AngeloStavrow
added
bug
AngeloStavrow
commented
Apr 14, 2024
Comment on lines
-97
to
-99
| if let languageCode = Locale.current.languageCode { | ||
| post.language = languageCode | ||
| post.rtl = Locale.characterDirection(forLanguage: languageCode) == .rightToLeft |
There was a problem hiding this comment.
This code was throwing warnings in newer versions of Xcode.
AngeloStavrow
commented
Apr 14, 2024
| NSApp.keyWindow?.contentViewController?.tryToPerform( | ||
| #selector(NSSplitViewController.toggleSidebar(_:)), with: nil | ||
| #if os(macOS) | ||
| WFNavigation( |
There was a problem hiding this comment.
We're essentially just wrapping these same views in our new WFNavigation view.
AngeloStavrow
commented
Apr 14, 2024
|
|
||
| var body: some View { | ||
| #if os(macOS) | ||
| NavigationSplitView { |
There was a problem hiding this comment.
Eventually we want to move the iOS app to use NavigationSplitView for iOS 16+
AngeloStavrow
commented
Apr 14, 2024
| @@ -126,18 +126,18 @@ struct PostListView: View { | |||
| .frame(height: frameHeight) | |||
| .background(Color(UIColor.systemGray5)) | |||
| .overlay(Divider(), alignment: .top) | |||
| .onReceive(NotificationCenter.default.publisher(for: UIApplication.didBecomeActiveNotification)) { _ in | |||
There was a problem hiding this comment.
Every time the app becomes active, this notification would fire in iOS 17 and navigate us back to the Post list view. Moving it to an onAppear modifier below fixes this behaviour will maintaining the list-refresh intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #248 and #256, and makes progress towards #224.
To prepare for the release of the Mac app, we get some dependencies upgraded for Sparkle (as well as docs for updating the app), and set up a new WFNavigation view that begins to incorporate SwiftUI's newer navigation paradigms into the Mac app. Some work has been done around the iOS app but it's a bit trickier to manage.
This PR also fixes a bug that would force the app to navigate back to the post list whenever you'd switch over to another app.