Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically build JS/CSS assets of WP Rocket plugin on develop branch #6649

Open
MathieuLamiot opened this issue May 21, 2024 · 0 comments

Comments

@MathieuLamiot
Copy link
Contributor

Context

This PR worked on running the gulp command automatically when releasing the plugin. Unfortunately, it was removed by mistake so it is not applied anymore. Additionally, we faced the issue within the team of forgetting to run the gulp command before testing a PR, making us lose time.

Expected behavior
Building JS and CSS assets for WP rocket plugin, currently manually handled with the gulp command should be automatically done.
There are several points to discuss to get the most efficient approach:

  • When to trigger the action? On release seems too late in the process. On commit to develop? When updating a PR pointing to develop?
  • How to leverage the action? As a reminder (run the minification process in the action and if the result is different, then fail the CI) or as an automated process (run the minification and commit)?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant