Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for email template is failing #516

Open
alexanmtz opened this issue Mar 22, 2020 · 2 comments
Open

Unit tests for email template is failing #516

alexanmtz opened this issue Mar 22, 2020 · 2 comments
Labels
beginner tasks status of beginner bug hiring Issues that can help you to solve hiring challenges node.js Taks that requires node.js knowledge starter issue for starter developers
Projects
Milestone

Comments

@alexanmtz
Copy link
Member

We have now some unit tests on our email templates.

Level

Beginner

Useful links

How to reproduce the user scenario

  • Replace xdescribe to describe to see the mail tests running

What you will need to complete this issue

Run the tests

Tips

xdescribe is a way to skip some unit tests

@alexanmtz alexanmtz added bug node.js Taks that requires node.js knowledge starter issue for starter developers beginner tasks status of beginner hiring Issues that can help you to solve hiring challenges labels Mar 22, 2020
@alexanmtz alexanmtz added this to the v1.7-apollo milestone Mar 22, 2020
@alexanmtz alexanmtz added this to To do in Gitpay via automation Mar 22, 2020
@namandangi
Copy link
Member

namandangi commented May 25, 2020

I'll work on this , assign me @alexanmtz

@alexanmtz
Copy link
Member Author

As discussed with @namandangi, we will need to do changes in canSendMail in constants, in order to allow mails to test Mail functions using Unit Tests, so we will need to create another issue to address this and start to remove this parameter and mock Sendgrid calls.

So once I have this issue created, we can close this one.

@alexanmtz alexanmtz removed this from the v1.7-apollo milestone Dec 15, 2020
@alexanmtz alexanmtz added this to the v2.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner tasks status of beginner bug hiring Issues that can help you to solve hiring challenges node.js Taks that requires node.js knowledge starter issue for starter developers
Projects
Gitpay
  
To do
Development

No branches or pull requests

2 participants