Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lint issues #1038

Open
alexanmtz opened this issue Jan 12, 2024 · 7 comments
Open

Fix Lint issues #1038

alexanmtz opened this issue Jan 12, 2024 · 7 comments
Assignees
Labels
beginner tasks status of beginner bug contribution
Milestone

Comments

@alexanmtz
Copy link
Member

When you do a push you will see many lint errors, and we need all those fixes so we can have the push hook green

@alexanmtz alexanmtz added this to the v2.0 milestone Jan 12, 2024
@alexanmtz alexanmtz added bug beginner tasks status of beginner contribution labels Jan 12, 2024
@alexanmtz
Copy link
Member Author

@KenjxJJ can you work on this?

@KenjxJJ
Copy link
Contributor

KenjxJJ commented Jan 16, 2024

Yes.

@alexanmtz alexanmtz assigned KenjxJJ and alexanmtz and unassigned alexanmtz Jan 16, 2024
@effaf
Copy link

effaf commented Feb 9, 2024

Hi @alexanmtz , I would like to work on this if there is no resolution yet.

@alexanmtz
Copy link
Member Author

Hello @effaf , there's no resolution yet; feel free to work on it.

@effaf
Copy link

effaf commented Feb 10, 2024

Hi @alexanmtz , thank you for assigning the issue. I have a few questions before I get started on this.

  1. I ran the command npx eslint --fix . , and could see 104 errors. A lot of these errors were parsing errors due to older eslint version. Can I change the ecmaVersion in the configuration file?
  2. Do you want me to comment out the console.log or delete it?
  3. A lot of libraries have been imported but not used. Would the maintainers prefer deleting the code or commenting it out?

@alexanmtz
Copy link
Member Author

Hi @alexanmtz , thank you for assigning the issue. I have a few questions before I get started on this.

  1. I ran the command npx eslint --fix . , and could see 104 errors. A lot of these errors were parsing errors due to older eslint version. Can I change the ecmaVersion in the configuration file?
  2. Do you want me to comment out the console.log or delete it?
  3. A lot of libraries have been imported but not used. Would the maintainers prefer deleting the code or commenting it out?

Hey, @effaf, thanks for jumping into this issue and your proactivity. You can change the ecmaVersion in the configuration, and we can eliminate all console.logs except the one with the comment // eslint-disable-next-line no-console

And we can remove the unused libraries.

@alexanmtz
Copy link
Member Author

Hey @effaf, some progress on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner tasks status of beginner bug contribution
Projects
None yet
Development

No branches or pull requests

4 participants
@alexanmtz @effaf @KenjxJJ and others