-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 5.3 code breaks older versions #1
Comments
Sure does. Given the huge number of PHP 5.2 sites out there this makes this module useless |
How will this code work for PHP 5.2? |
I added a comment on d.o: http://drupal.org/node/1439762#comment-6270388, as this seems to be the patch where this is coming from. |
Created a fork that removes the dependency on php-5.3: https://github.com/jlyon/ctools_automodal. I will also upload a patch to http://drupal.org/node/1439762. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
$convert_to_regexp = function ($value) { return preg_replace('/%[^\/]*/', '[^/]+', $value); };
These inline functions will break on php < 5.3
The text was updated successfully, but these errors were encountered: