Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.3 code breaks older versions #1

Open
rv0 opened this issue Apr 5, 2012 · 4 comments
Open

PHP 5.3 code breaks older versions #1

rv0 opened this issue Apr 5, 2012 · 4 comments

Comments

@rv0
Copy link

rv0 commented Apr 5, 2012

$convert_to_regexp = function ($value) { return preg_replace('/%[^\/]*/', '[^/]+', $value); };

These inline functions will break on php < 5.3

@Jonno
Copy link

Jonno commented Apr 21, 2012

Sure does. Given the huge number of PHP 5.2 sites out there this makes this module useless

@theodorosploumis
Copy link

How will this code work for PHP 5.2?

@jlyon
Copy link

jlyon commented Jul 24, 2012

I added a comment on d.o: http://drupal.org/node/1439762#comment-6270388, as this seems to be the patch where this is coming from.

@jlyon
Copy link

jlyon commented Jul 24, 2012

Created a fork that removes the dependency on php-5.3: https://github.com/jlyon/ctools_automodal. I will also upload a patch to http://drupal.org/node/1439762.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants