New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All logic relying on os.path.sep
is wrong on Windows
#314
Labels
bug
for issue
Comments
@RunDevelopment I don't own Windows computer so am not able to play around the difference of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Provide environment information
Python: 3.8.2
gdown: main
What OS are you using?
Windows 10
Describe the Bug
All the logic using
os.path.sep
is incorrect on Windows, because Windows paths treat/
the same as a\
. However, gdown only usesos.path.sep
(which is\
on Windows) meaning that it treats perfectly valid paths incorrectly.The underlying issue is that gdown assumes that the primary path separator is the only path separator, which is not true.
Example of an incorrect usage of
os.path.sep
to detect directory paths.Expected Behavior
Support paths with both
/
and\
on Windows.To Reproduce
No response
The text was updated successfully, but these errors were encountered: