Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug:Git branches suggestions still appear after being deleted #2026

Open
3 tasks done
anelrh26 opened this issue Jun 25, 2023 · 3 comments
Open
3 tasks done

bug:Git branches suggestions still appear after being deleted #2026

anelrh26 opened this issue Jun 25, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@anelrh26
Copy link

Checks

  • I have searched github.com/withfig/fig/issues and there are no duplicates of my issue
  • I have run fig doctor in the affected terminal session
  • I have run fig restart and replicated the issue again

Operating system

macOS 13.3.1 (22E772610a)

Expected behaviour

If a branch is deleted with git branch -D the branch name shouldn't appear in the suggestions when git checkout is typed

Actual behaviour

After deleting local branches with git branch -D, the branch names still appear in the suggestions when git checkout is typed

Steps to reproduce

  • delete a branch git branch -D <branch>
  • type git checkout.

Result
Fig suggestions sill shows the deleted branch

Environment

fig-details:
  - 2.16.0
hardware-info:
  - model:
  - model-id:
  - chip-id: Apple M1 Pro
  - cores: 10
  - mem: 16.00 GB
os-info:
  - macOS 13.3.1 (22E772610a)
environment:
  - shell: /bin/zsh
  - terminal: iterm
  - cwd: /Users/myUser/Personal/personal-project
  - exe-path: /usr/local/bin/fig
  - install-method: unknown
  - env-vars:
    - FIGTERM_SESSION_ID: ad47a211-fe62-485b-8e90-fa24fe589ab3
    - FIG_SET_PARENT_CHECK: 1
    - FIG_TERM: 2.16.0
    - PATH: /usr/local/opt/postgresql@13/bin:/Users/myUser/.asdf/shims:/usr/local/opt/asdf/libexec/bin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/myUser/.fig/bin:/Users/user/.local/bin
    - SHELL: /bin/zsh
    - TERM: xterm-256color
    - __CFBundleIdentifier: com.googlecode.iterm2
    - FIG_PID: 10452
    - FIG_SET_PARENT: ad47a211-fe62-485b-8e90-fa24fe589ab3
@grant0417
Copy link
Member

grant0417 commented Jul 17, 2023

We cache the branch suggestions, this might be a better issue for https://github.com/withfig/autocomplete as the caching logic is stored in that repo.

@mschrage mschrage transferred this issue from withfig/fig Jul 18, 2023
@grant0417 grant0417 added bug Something isn't working and removed NEED_TO_LABEL labels Jul 29, 2023
@esau-morais
Copy link
Contributor

i'll give this issue a try

@esau-morais
Copy link
Contributor

esau-morais commented Aug 12, 2023

after trying to reproduce this bug, here's what i've got:

  1. it doesn't happen with local branches
  2. if I push to the upstream and delete it directly there, it'll still suggest till you git fetch

shouldn't this be the expected behaviour?
cc. @grant0417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants