-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing hybrid mode on Cookie #7215
Comments
Thank you for raising this @jamesli2021 ! I agree and it's actually on my list to convert some of our wording over from "modes" ( @Princesseuh - I went to look in https://github.com/withastro/astro/blob/main/packages/astro/src/core/errors/errors-data.ts for this error but I'm having trouble finding it. Is it possible we don't have a docs entry for this one? In general, I think we'll make a task to do a sweep of SSR related errors and make sure they refer to the specific endpoint/route being prerendered or not, vs the output mode, since that doesn't guarantee that every page uses SSR. |
We only have pages for errors, this seems to be a random warning in the console, so it's most likely somewhere random in Astro. |
Alright, treasure hunt, it is! Let's find this warning in the Astro code base 😅 |
Gotcha! Here's where the warning comes from: And here's a minimal reproduction example: |
I'd really like to see this fixed, it is one of a couple of warnings that gets spewed everywhere in my console when I run a build and makes it much harder to find actual problems. |
📝 Issue Description
Unclear about
hybrid
mode.📋 On which page(s) it occurs
https://docs.astro.build/en/guides/server-side-rendering/#on-demand-rendering-features
🤔 Expected Behavior
What do the readers understand from this?
Extract from doc:
In server and hybrid (with opt-out prerender) modes, a page or API endpoint can check, set, get, and delete cookies.
👀 Current Behavior
When I set to
output: hybrid
in astro config file, the terminal can confusing for newbies, I know we need to opt-out of pre-render. But this warning need to be clear.🖥️ Browser
NA
📄 Additional Information
No response
The text was updated successfully, but these errors were encountered: