fix(upgrade): use preferred-pm instead of which-pm-runs #11139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 448f093 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
May 24, 2024
matthewp
approved these changes
May 24, 2024
Merged
gacek1123
reviewed
May 25, 2024
| @@ -8771,6 +8771,13 @@ packages: | |||
| resolution: {integrity: sha512-37i+OaWTh9qeK4LSHPsyRC7NahnGotNuZvjLSgcPzblpHB3rrCJxAOgI5gCdKm7coonsaX1Of0ILiTcnZjbfxA==} | |||
| dev: true | |||
|
|
|||
| /@types/[email protected]: | |||
| resolution: {integrity: sha512-Ub1de7EkdavsyM1KNrTb1K1QL+ISepEELELh2QWccyDcVEcyUDiGoYzzOJfonpGNwpymYXY13oRFpXQluGOC5w==} | |||
| deprecated: This is a stub types definition. preferred-pm provides its own type definitions, so you do not need this installed. | |||
There was a problem hiding this comment.
Seems that the types package isn't needed?
There was a problem hiding this comment.
Good catch, I'll update this when possible!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@astrojs/upgrade wrongfully used the current package manager used to run the command instead of the package manager used to install the project its run in. This normally would be fine, however many people uses
npxeven when using pnpm and other package managers, so using the package manager of the project ends up working betterNotice it now using pnpm despite using npx in this screenshot.
Testing
Tested manually, see screenshot
Docs
N/A